Added FindMax to Maths #831
Conversation
|
This pull request introduces 1 alert when merging e17e0d0 into 09eebc4 - view on LGTM.com new alerts:
|
raklaptudirm
added
algorithm
Added FindMax test
|
This pull request introduces 1 alert when merging 4e34c7d into 2619ab6 - view on LGTM.com new alerts:
|
|
Fix the raised errors. |
| */ | ||
|
|
||
| export const findMax = (arr) => { | ||
| if (arr.length === 0) { return 'Array is empty' } |
There was a problem hiding this comment.
Throw an error, not a string.
There was a problem hiding this comment.
Agree with @raklaptudirm. Whenever you know the conditions where your function will fail (I call them nice errors) then throw then instead of handling them yourself (by returning a string) throw an error instead so that the user can handled them according to their business rules.
| */ | ||
|
|
||
| export const findMax = (arr) => { | ||
| if (arr.length === 0) { return 'Array is empty' } |
There was a problem hiding this comment.
Agree with @raklaptudirm. Whenever you know the conditions where your function will fail (I call them nice errors) then throw then instead of handling them yourself (by returning a string) throw an error instead so that the user can handled them according to their business rules.
3 participants
Welcome to JavaScript community
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare not